Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of batch processing in README.md is misleading #420

Open
michael-o opened this issue Oct 15, 2024 · 0 comments
Open

Usage of batch processing in README.md is misleading #420

michael-o opened this issue Oct 15, 2024 · 0 comments

Comments

@michael-o
Copy link

The README says:

batch conversion of multiple files: pngquant *.png

Let's try:

$ /tmp/pngquant/bin/pngquant --skip-if-larger --verbose --ext .png -f 'inputs/Bilder.toy/*'
inputs/Bilder.toy/*:
  error: cannot open inputs/Bilder.toy/* for reading
There were errors quantizing 1 file out of a total of 1 file.

Does not work.
Reason: The README relies on the fact that the tool is run from a shell which supports file globbing, but the tool itself does not use glob(3). Better replace with multiple filenames. As soon as I run this example from a non-shell, e.g., Java, Python, popen it will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant