SyroComp_CompBlock: Prevent stack buffer overflow #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18.
I found a stack buffer overflow in SyroComp_CompBlock that didn't seem to result in any bugs when I compiled code with GCC.. however I consistently ran into problems when compiling to WebAssembly with Emscripten.
In this code:
volcasample/syro/korg_syro_comp.c
Lines 394 to 403 in b0ed615
We can see that once
jhas been incremented to 4, the index 4 ofBitBase(which doesn't exist) will be checked for the remainder of the loop. If the out of bounds memory happens to matchiby accident, then we will get a false positive and write incorrect data.Adding the index guard in this pull request solves the problem and makes my tests pass (for both GCC and Emscripten).