Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveMessaging.load_activemessaging should not load ThreadedPoller #25

Open
subakva opened this issue Nov 30, 2012 · 0 comments
Open

Comments

@subakva
Copy link
Contributor

subakva commented Nov 30, 2012

Including ActiveMessaging in a Rails application will trigger ActiveMessaging.load_activemessage which in turn requires activemessage/threaded_poller.

This means that every time the Rails environment is loaded, it loads celluloid, which prints this method every time the process exits:

Terminating 4 actors...
Shutdown completed cleanly

At best, this is an annoyance, at worst, it's spawning 4 useless threads every time the Rails environment is loaded.

Given that the class isn't used unless the application executing the threaded_poller script, it should not be required in that file.

Expect a pull request shortly. :)

subakva added a commit to carbonfive/activemessaging that referenced this issue Nov 30, 2012
kookster added a commit that referenced this issue Dec 3, 2012
…oller-25

[#25] Only require threaded_poller where necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant