Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The presence of a source should not be required for a rule to be triggered #342

Open
1 task done
jmle opened this issue Oct 1, 2024 · 1 comment
Open
1 task done
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jmle
Copy link
Contributor

jmle commented Oct 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5.3

Priority

Critical

Current Behavior

Currently, for a rule to be picked up by kantra, is not enough for it to have a target label:

  labels:
  - konveyor.io/target=quarkus

it needs to have at least one source label too:

  labels:
  - konveyor.io/source=java-ee
  - konveyor.io/source=jakarta-ee
  - konveyor.io/target=quarkus

This doesn't make sense, as sources should not be mandatory.

Expected Behavior

A rule with only targets:

  labels:
  - konveyor.io/target=quarkus

should be picked up without the need of having sources.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Create a rule without source labels, but with a target label for quarkus
  2. Run against an application with --target quarkus
  3. See how the rule is not even picked up

Environment

Any environment

Anything else?

No response

@jmle jmle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 1, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants