Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for overriding rules #178

Open
kthatipally opened this issue Mar 15, 2024 · 2 comments
Open

[Feature] Add support for overriding rules #178

kthatipally opened this issue Mar 15, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kthatipally
Copy link
Contributor

kthatipally commented Mar 15, 2024

We're requesting the addition of a feature that would allow us to override rules within downstream repositories, similar to the functionality provided by Windup (https://github.com/windup/windup-rulesets/tree/master/rules/rules-overridden-azure).
This capability will enable us to tailor rules to specific targets and messages, thus enhancing the flexibility and adaptability.
The ability to customize messages based on different targets would be particularly valuable.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 15, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 15, 2024
@kthatipally kthatipally changed the title [Feature] Add support to overriding rules [Feature] Add support for overriding rules Mar 15, 2024
@eemcmullan eemcmullan added enhancement New feature or request kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed enhancement New feature or request needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 19, 2024
@shawn-hurley
Copy link
Contributor

IIUC the use case, Ruleset A wants to use all the rules from Ruleset B and then wants to selectively override specific outputs and then for the output to look like a single ruleset was run.

Hopefully, that is correct, but if it is incorrect, then ignore the rest of this, and we can chat about the misunderstanding of the use case!

As we move into the multiple providers, I think a ruleset should be stand-alone, and intra-rule dependencies should not be something that we add. More specifically, If you are running Ruleset A, you will get the output for Ruleset A. Ruleset A's output should not be able to interfere with Ruleset B's output.

I have two questions that I think we need to answer before starting down this path and designing intra-rule dependencies.

  1. Why can't both output exist's.
  2. If you want to re-use a ruleset and apply changes, why isn't a fork and re-name of that ruleset sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants