Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fmt.Println in Backoff handler with logger #299

Closed
pranavgaikwad opened this issue Aug 21, 2023 · 2 comments
Closed

Replace fmt.Println in Backoff handler with logger #299

pranavgaikwad opened this issue Aug 21, 2023 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@pranavgaikwad
Copy link
Contributor

I think this is an oversight

analyzer-lsp/jsonrpc2/backoff_handler.go

Line 132 in 7cb1d66

fmt.Printf("deleting request key")

We need to replace above with b.loggeer.V(7).Info()
@pranavgaikwad pranavgaikwad added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 21, 2023
@tanryberdi
Copy link

@pranavgaikwad this issue was resolved, i think? wdyt? this changes already there

@pranavgaikwad
Copy link
Contributor Author

@tanryberdi thank you for bringing to attention, fixed via #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
No open projects
Konveyor Analyzers
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanryberdi @pranavgaikwad