Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-maps-react is not supported in React 17 #198

Open
Simply007 opened this issue Mar 14, 2022 · 1 comment
Open

google-maps-react is not supported in React 17 #198

Simply007 opened this issue Mar 14, 2022 · 1 comment

Comments

@Simply007
Copy link
Contributor

Brief bug description

google-maps-react is not supported in React 17

Repro steps

  1. Remove node_modules and package-lock.json
  2. Run npm i

Error:

ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN   react@"^17.0.2" from the root project
npm WARN   9 more (@simply007org/kontent-react-components, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"~0.14.8 || ^15.0.0 || ^16.0.0" from [email protected]
npm WARN node_modules/google-maps-react
npm WARN   google-maps-react@"^2.0.6" from the root project
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react
npm WARN   peer react@"~0.14.8 || ^15.0.0 || ^16.0.0" from [email protected]
npm WARN   node_modules/google-maps-react
npm WARN     google-maps-react@"^2.0.6" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react-dom
npm WARN   react-dom@"^17.0.2" from the root project
npm WARN   2 more (@simply007org/kontent-react-components, react-scroll)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"~0.14.8 || ^15.0.0 || ^16.0.0" from [email protected]
npm WARN node_modules/google-maps-react
npm WARN   google-maps-react@"^2.0.6" from the root project
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"~0.14.8 || ^15.0.0 || ^16.0.0" from [email protected]
npm WARN   node_modules/google-maps-react
npm WARN     google-maps-react@"^2.0.6" from the root project

Expected behavior

No error - try to find an alternative package for the Google Maps component.

@IvanKiral
Copy link
Contributor

We decided to remove the map from the react app.
There is commit of not fully completed react component for MapContainer 43df9ad

It was deleted in the following commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants