Use the public class/keyword instead of internal to allow customized HttpClient

[ddo72]

Motivation

Customers want to use a customize httpClient (with proxy) when creating a managementCient.

Proposed solution

Replace internal by public for the following classes:

• ActionInvoker
• EndpointUrlBuilder
• ManagementHttpClient
• MessageCreator
• ModelProvider

[pokornyd]

hello and thank you for your submission. could you share some more details on what exactly you're trying to achieve? I see the classes you mentioned are all related to the following interface:

management-sdk-net/Kontent.Ai.Management/Modules/HttpClient/IManagementHttpClient.cs

Line 11 in 366e496

public interface IManagementHttpClient

Is your goal to use the internal implementation for implementing this interface, with the exception of httpClient, which should be your custom one?

if that is the case, I think we could add a paramater to ManagementClient constructor or ManagementOptions, which, if present, would make use of the overloaded constructor for ManagementHttpClient to be passed as IHttpProvider parameter.

would the above solution work in your scenario?

[daninden]

The Management client creates a ManagementHttpClient which creates a new HttpClient, but this is your internal HttpClient type.
There is no option to inject a System.Net.Http.HttpClient into this (with in our case configured proxy settings).
We currently forked the code to make this possible for us.

Our suggestion would be to remove the internally specified/created HttpClient and IHttpClient type (as they conflict with the existing HttpClient), and allow a registered IHttpClient on the ManagementClient.

builder.Services.AddHttpClient<IManagementClient, ManagementClient>() .ConfigurePrimaryHttpMessageHandler(() => new HttpClientHandler() { Proxy = webProxy });