Ensure ToDynamic is called consistently when converting a Element(s) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify FromDynamic conversion for TaxonomyElement * Fix unit test
* Attempted to do RichTextElement but it broke too many tests, so may need further thought * Make ToDynamic more consistent in the Element types * Improve unit test coverage
|
I made an attempt at aligning RichTextElement but it proved to be tricky. Lots of tests assume the dynamic structure in different places, so after the refactor ~70 tests began to fail. I reverted them for now, maybe an opportunity for later? |
kylejuliandev
changed the title
|
hey, thank you for the submission and an update regarding the tests. I'll review the proposed changes and see about refactoring the tests or splitting it into a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #265
Checklist
How to test
If manual testing is required, what are the steps?