Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Make the SDK tracking header load the library version automatically #54

Open
Simply007 opened this issue Feb 1, 2018 · 1 comment
Open

Spike: Make the SDK tracking header load the library version automatically #54

Simply007 opened this issue Feb 1, 2018 · 1 comment
Labels
enhancement groomed The issue has been groomed and should be in a good shape. hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted refactoring up-for-grabs

Comments

@Simply007
Copy link
Contributor

Simply007 commented Feb 1, 2018 •
edited by petrsvihlik
Loading

The SDK sends a version tracking header in the following form: X-KC-SDKID: packagist.org;kentico-kontent/delivery-sdk-php;0.9.1 with every request. This was implemented in #43

Currently, the tracking header is hardcoded in the DeliveryClient.php and needs to be updated with every release

The goal of this task is to find a way of updating this version automatically (using a pre/post build action) or loading it from the composer.json somehow (after packagist sets it up during release).

We are open to any other ideas! :-)
@petrsvihlik petrsvihlik added this to the 2.0 - Personalization milestone Feb 2, 2018
@petrsvihlik petrsvihlik modified the milestones: 1.6, 2.0 Jun 7, 2018
@petrsvihlik petrsvihlik changed the title Make SDK version tracking header automatically loads library version Make the SDK tracking header load the library version automatically Aug 20, 2018
@petrsvihlik petrsvihlik changed the title Make the SDK tracking header load the library version automatically Research&Implement: Make the SDK tracking header load the library version automatically Aug 20, 2018
@petrsvihlik petrsvihlik changed the title Research&Implement: Make the SDK tracking header load the library version automatically Spike: Make the SDK tracking header load the library version automatically Aug 20, 2018
@petrsvihlik petrsvihlik added groomed The issue has been groomed and should be in a good shape. hacktoberfest https://hacktoberfest.digitalocean.com/ labels Aug 20, 2018
@petrsvihlik petrsvihlik removed this from the 2.0 milestone Oct 1, 2018
@arffsaad
Copy link

arffsaad commented Oct 3, 2024

Hey, I would be interested to pick this up! If it's okay, you can assign it to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement groomed The issue has been groomed and should be in a good shape. hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted refactoring up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Simply007 @petrsvihlik @arffsaad