Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubefirst terraform command should throw error when not able to connect to Vault #2300

Open
1 task done
fharper opened this issue Oct 16, 2024 · 2 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@fharper
Copy link
Contributor

fharper commented Oct 16, 2024

Which version of kubefirst are you using?

2.6.1

Which cloud provider?

None specific

Which DNS?

None specific

Which installation type?

None specific

Which distributed Git provider?

None specific

Did you use a fork of gitops-template?

No

Which Operating System?

None specific

What is the issue?

If the command kubefirst terraform set-env isn't able to connect to Vault (example, someone pasted the --vault-token with a % at the end which isn't valid (not sure if happen only in this case on in all bad token cases), the command run without any error, but obviously won't work, and generate the .env file it is supposed to do. The command should return an error in that case.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fharper fharper added the bug Something isn't working label Oct 16, 2024
@fharper
Copy link
Contributor Author

fharper commented Oct 16, 2024

@konstructcarrie FYI, the issue you had last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant