From 4fe80ca6c3f0d733e02600f7a62f0a777492507e Mon Sep 17 00:00:00 2001 From: Martin Malina Date: Mon, 4 Nov 2024 09:03:07 +0530 Subject: [PATCH] fix: contributing doc to say task tests are required This recently came up in a PR: https://github.com/konflux-ci/release-service-catalog/pull/656 We definitely do require tests for all new tasks. For existing tasks, we mostly do as well, but there are still three tasks without tests: - base64-encode-checksum - create-internal-request - prepare-validation Signed-off-by: Martin Malina --- CONTRIBUTING.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 693b15e24..e5286e146 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -130,8 +130,7 @@ script will install the task CR locally. For example: name: apply-mapping ``` -Currently task tests are not required, so if a task version directory is modified -in a PR and there are no tests, that directory will be skipped. +Task tests are required for all new tasks. For task updates, if the task doesn't currently have tests, adding them is not strictly required, but is recommended. ##### Testing scenarios where the Task is expected to fail