Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate git-provider-url annotation #379

Open
ralphbean opened this issue Dec 5, 2024 · 0 comments
Open

Validate git-provider-url annotation #379

ralphbean opened this issue Dec 5, 2024 · 0 comments

Comments

@ralphbean
Copy link
Member

ralphbean commented Dec 5, 2024

I ran into a case in the Fedora cluster where a user entered gitlab.com for their git-provider-url. Build-service processed this without a problem and passed it on to the PaC Repository. PaC accepted it no problem, but when it tried to operate on an incoming webhook, it failed hard because the url was missing its https:// prefix.

This is a request for build-service to start validating that annotation. If it doesn't conform to a url schema, the Component should be rejected from submission.

Related issue for PaC filed at openshift-pipelines/pipelines-as-code#1852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant