Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author confirmation is lost #17

Open
muan opened this issue May 11, 2020 · 2 comments
Open

Author confirmation is lost #17

muan opened this issue May 11, 2020 · 2 comments

Comments

@muan
Copy link
Contributor

muan commented May 11, 2020

Added in #9, removed in #16. Not sure if this was intentionally, but I personally would still like a confirmation so that I know which user the script found.

@koddsson
Copy link
Owner

Ah, I removed it since I thought the script was too verbose. I don't mind adding it back but I might hide it behind a log level in the future.

@muan
Copy link
Contributor Author

muan commented May 13, 2020

That'd be great. I'd be happy to pass -v.

I think I want the confirmation because I don't fully trust the script to get me what I want reliably.

For example, before github user fetch was properly supported, I do david to get David Graham in git log because his email does not contain the string dgraham, but it doesn't always work because there can be multiple davids. At the same time, if you work with someone with a short github username, like mdo, you'll get the first git log match, which could be Ben Emdon, or it could be [email protected], then I have to cat .git/config to confirm.

Perhaps this can be improved with a source flag? which will definitely let me trust the script more. coworking-with mdo --gh or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants