Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox inside Popover triggers focus-visible on click #39

Closed
tienpv222 opened this issue Jan 12, 2023 · 2 comments · Fixed by #52 or #53
Closed

Checkbox inside Popover triggers focus-visible on click #39

tienpv222 opened this issue Jan 12, 2023 · 2 comments · Fixed by #52 or #53
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@tienpv222
Copy link

Describe the bug
When inside Popover, toggling a Checkbox with mouse activates data-focus-visble.

Reproduce
https://stackblitz.com/edit/node-rpxsaq
@fabien-ml
Copy link
Collaborator

Hi thanks for the bug report.

I think it's the same bug as in solid-aria (solidjs-community/solid-aria#60) since both are the same port of react-aria.

However I didn't found a solution for this yet. 😖

@fabien-ml fabien-ml added bug Something isn't working help wanted Extra attention is needed labels Jan 12, 2023
@fabien-ml
Copy link
Collaborator

Looks like it's an unsolved problem in react-aria too (adobe/react-spectrum#2380).

fabien-ml added a commit that referenced this issue Jan 15, 2023
@fabien-ml
fix: #39
301be43
fabien-ml added a commit that referenced this issue Jan 15, 2023
@fabien-ml
Merge pull request #51 from fabien-ml/hotfix/#50
7784435 
hotfix: #39 and #50
@fabien-ml fabien-ml mentioned this issue Jan 15, 2023
Merged
@github-actions github-actions bot mentioned this issue Jan 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: changeset v0.3.1 kobaltedev/kobalte
chore: update versions kobaltedev/kobalte
2 participants
@fabien-ml @tienpv222