-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riak and DLService scaling #75
Labels
env/all
To indicate something that applies to all environments
improvement
Improvements to an existing component
Comments
Agree. Creating a new branch "feature/dls_scaling" for this feature.
…On Wed, Jul 22, 2020 at 11:12 AM Istemi Ekin Akkus ***@***.***> wrote:
Currently, the riak and DLService components cannot scale automatically
due to their static configuration: when the DLService is started, it is
passed the riak nodes as well as other DLService nodes as a parameter.
However, these values are never updated after the components start. As a
result, scaling up the services (e.g., add another riak replica, add
another DLService node) does not update already started components.
We should make the DLService update its view of the available riak nodes
dynamically during runtime. When a riak node is added to or removed from
the platform, this should be reflected on the DLService node's view.
Similarly, DLService should also learn whether other DLService nodes are
added or removed at runtime. With the new design for caching (#10
<#10>), this might not
be necessary.
Also, check out @manuelstein <https://github.com/manuelstein>'s comments
on the PR #74 <#74>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#75>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQSEDEU2YM5CVOSYZAIQGDR42UOLANCNFSM4PEP5LAA>
.
|
iakkus
added
env/all
To indicate something that applies to all environments
improvement
Improvements to an existing component
labels
Jul 22, 2020
I am not sure whether we should actually spend the effort on making the DLService scale as such. We might end up putting it into the sandbox, depending on the outcome of the Redis caching related issue #10. But now that I think about it, perhaps it's good to have a mechanism that will update the view of the available riak nodes, regardless where that mechanism runs (e.g., in the sandbox, on the node). |
Yes, I think in this branch we should achieve the following two things:
1) during deployment, let operators decide whether strong/eventual
consistency is needed. DL service reports errors or won't start when
conditions are not met.
2) let DL service be aware of riak node changes.
…On Thu, Jul 23, 2020 at 9:20 AM Istemi Ekin Akkus ***@***.***> wrote:
I am not sure whether we should actually spend the effort on making the
DLService scale as such. We might end up putting it into the sandbox,
depending on the outcome of the Redis caching related issue #10
<#10>.
But now that I think about it, perhaps it's good to have a mechanism that
will update the view of the available riak nodes, regardless where that
mechanism runs (e.g., in the sandbox, on the node).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQSEDEIQGEYQ3CQRA6CGMLR47QEHANCNFSM4PEP5LAA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
env/all
To indicate something that applies to all environments
improvement
Improvements to an existing component
Currently, the riak and DLService components cannot scale automatically due to their static configuration: when the DLService is started, it is passed the riak nodes as well as other DLService nodes as a parameter. However, these values are never updated after the components start. As a result, scaling up the services (e.g., add another riak replica, add another DLService node) does not update already started components.
We should make the DLService update its view of the available riak nodes dynamically during runtime. When a riak node is added to or removed from the platform, this should be reflected on the DLService node's view.
Similarly, DLService should also learn whether other DLService nodes are added or removed at runtime. With the new design for caching (#10), this might not be necessary.
Also, check out @manuelstein's comments on the PR #74.
The text was updated successfully, but these errors were encountered: