Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name and password change operations #6

Closed
iakkus opened this issue May 7, 2020 · 7 comments
Closed

Name and password change operations #6

iakkus opened this issue May 7, 2020 · 7 comments
Assignees
Labels
feature_request New feature request finished When a bug is fixed or a feature has been implemented

Comments

@iakkus
Copy link
Member

iakkus commented May 7, 2020

[Environment]: Kubernetes, bare metal
[Known affected releases]: master (includes all releases)

The current management service does not allow a user to change or reset her password.

Besides the management service, this change would have an effect on the GUI, and possibly the SDK and CLI.

@iakkus iakkus added the feature_request New feature request label May 7, 2020
@iakkus
Copy link
Member Author

iakkus commented May 8, 2020

Probably two more actions: changePassword and resetPassword.

Resetting password could be facilitated via a unique, nonce-based, temporary link sent to the user’s email address. When the user clicks the link, she could be sent to a page, where she can create a new password.

@iakkus iakkus self-assigned this May 8, 2020
@iakkus
Copy link
Member Author

iakkus commented May 8, 2020

Started implementation at branch feature/password_operations.

@iakkus iakkus added the in progress This issue is already being fixed label May 8, 2020
@iakkus
Copy link
Member Author

iakkus commented May 11, 2020

Related issue: #13

@manuelstein
Copy link
Collaborator

can we make this a more generic user update? maybe updating the email address or the name is something a user would want. It might be better to integrate with an authorisation service and treat tenants by their id only. This would also close a lot of privacy pitfalls.

@iakkus
Copy link
Member Author

iakkus commented Jun 3, 2020

Yes, allowing also the name change makes sense.

The email change is more involved, because the email is used to initialize the storage endpoint. However, looking at the code right now, I think that should also be possible without changing the storage endpoint (i.e., it's just a hash anyway).

I also agree that we should/could support a third party authorisation service. Perhaps that's a feature that one would want if we're talking about a hosted service. Nonetheless, I think that should be a separate issue.

@iakkus
Copy link
Member Author

iakkus commented Jun 3, 2020

Actually, I take the email comment above back: the email is used (at least, currently) as a prefix for keys that stores list of workflows and function as well as any other user data in the system.

Perhaps, once we update the management service to use other data structures (see issue #8), we can make it so that we enable the data to be stored associated with a unique id that is permanent, but create a mapping between ids and up-to-date emails.

@iakkus iakkus changed the title Password operations Name and password change operations Jun 3, 2020
@iakkus iakkus added the finished When a bug is fixed or a feature has been implemented label Jun 13, 2020
@iakkus
Copy link
Member Author

iakkus commented Jun 13, 2020

Merged into 'develop'.

@iakkus iakkus closed this as completed Jun 13, 2020
@iakkus iakkus removed the in progress This issue is already being fixed label Jun 13, 2020
@iakkus iakkus mentioned this issue Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request New feature request finished When a bug is fixed or a feature has been implemented
Projects
None yet
Development

No branches or pull requests

3 participants