Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change test workflows to use ASL #20

Closed
iakkus opened this issue May 25, 2020 · 1 comment
Closed

change test workflows to use ASL #20

iakkus opened this issue May 25, 2020 · 1 comment
Assignees
Labels
finished When a bug is fixed or a feature has been implemented good first issue Good for newcomers improvement Improvements to an existing component

Comments

@iakkus
Copy link
Member

iakkus commented May 25, 2020

[Environment]: Kubernetes, bare metal
[Known affected releases]: master (includes all releases)

The tests utilize a mix of ASL as well as KNIX-specific workflow descriptions. It'd be great to make every test to utilize ASL.

Many tests can be migrated at this point. There are some tests that depend on Issue #19.

@iakkus iakkus added good first issue Good for newcomers improvement Improvements to an existing component labels May 25, 2020
@iakkus iakkus self-assigned this May 27, 2020
iakkus pushed a commit that referenced this issue May 27, 2020
…-specific flags, so they are going to be handled from branch 'feature/asl_knix_flag'. fixes #20
@iakkus
Copy link
Member Author

iakkus commented May 27, 2020

Remaining tests:

  • tests/performance2/: Uses checkpoints flag.

  • tests/dynamic_parallel_execution_groups/: Uses session functions.

  • tests/performance_interaction_latency/: Uses checkpoints flag.

  • tests/session_support/: Uses session functions.

  • tests/workflow_error_handling/: Uses "next" with multiple inputs to check the workflow error flag. In ASL, this could be achieved via a Parallel branch, all of which will fail when a branch fails. This test probably becomes obsolete and will be removed with branch feature/asl_knix_flag.

  • tests/helloworld/helloworld-knix.json: This test case utilizes the KNIX description on purpose and will not be touched.

These tests will be handled from the other branch feature/asl_knix_flag.

@iakkus iakkus closed this as completed May 27, 2020
@iakkus iakkus added the finished When a bug is fixed or a feature has been implemented label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
finished When a bug is fixed or a feature has been implemented good first issue Good for newcomers improvement Improvements to an existing component
Projects
None yet
Development

No branches or pull requests

1 participant