Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autoescaping for Twig 2.x #102

Open
andriokha opened this issue Feb 20, 2023 · 0 comments · May be fixed by #103
Open

Fix autoescaping for Twig 2.x #102

andriokha opened this issue Feb 20, 2023 · 0 comments · May be fixed by #103

Comments

@andriokha
Copy link

andriokha commented Feb 20, 2023 •
edited
Loading

Thanks for a very useful project!

Currently there's a boolean configuration option called autoescape that gets passed directly to \Twig\Environment::__construct() in

twig-renderer/src/TwigRenderer.php

Lines 50 to 52 in 4b09a3f

$twig = new \Twig_Environment($loaders, [
'debug' => $this->config['debug'],
'autoescape' => $this->config['autoescape'],

In Twig 1:

  • true is the same as html and uses that escaping strategy
  • false disables auto-escaping

In Twig 2 true was removed as an option (so to get the old true behaviour you should pass html).

It occurred to me that we could expose the full range of options, but I'm not sure if there's really any demand for that.
andriokha added a commit to FabbDev/twig-renderer that referenced this issue Feb 20, 2023
@andriokha
Fix autoescaping for Twig 2.x
8581206 
Twig 1 and 2 both have an autoescape constructor parameter. In 1.x
passing false was the same as passing 'html'. In 2.x you must explicitly
pass 'html'.

See
- https://github.com/twigphp/Twig/blob/0887422319889e442458e48e2f3d9add1a172ad5/src/Environment.php#L111
- https://github.com/twigphp/Twig/blob/872646a70ff83b3628d50c9bafa117af9f1da59e/src/Environment.php#L92

Closes knapsack-cloud#102.
@andriokha andriokha linked a pull request Feb 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix autoescaping for Twig 2.x FabbDev/twig-renderer
1 participant
@andriokha