Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: download contract artifacts instead of compiling [3] #1483

Open
4 tasks
greged93 opened this issue Oct 22, 2024 · 0 comments
Open
4 tasks

dev: download contract artifacts instead of compiling [3] #1483

greged93 opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@greged93
Copy link
Collaborator

greged93 commented Oct 22, 2024

Describe the enhancement request

In our make setup, we compile the Kakarot contracts coming from the kakarot submodule. This takes quite the time and adds complexity because we need to setup up the kakarot submodule correctly and integrate changes the submodule does to its own setup.

In order to avoid this step, we can:

  • Use the deployer image in the RPC and hive docker files with FROM path/to/deployer as deployer -> COPY --from=deployer kakarot/artifacts/path kakarot/artifacts/path/destination
  • Use the deployer coupled with docker cp in order to get the artifacts locally (this change should be made in our setup recipe)
  • Use the docker deployer for the end 2 end tests (script e2e_pipeline to be udpated).
  • Remove the Kakarot submodule from the RPC

Duration: 3 hours

@greged93 greged93 added the enhancement Enhancement of the code, not introducing new features. label Oct 22, 2024
@greged93 greged93 changed the title dev: download contract artifacts instead of compiling dev: download contract artifacts instead of compiling [3] Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
Status: 🔖 Current sprint
Development

No branches or pull requests

1 participant