Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch support #27

Open
ozwaldorf opened this issue May 2, 2023 · 4 comments
Open

Touch support #27

ozwaldorf opened this issue May 2, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ozwaldorf
Copy link

The current touch support is poor, tested on wayland. Dragging a finger around doesn't draw a line as expected, but instead starts zooming the canvas.

@vishisht-dubey
Copy link

hey @ozwaldorf i would like to work on this issue please assign this to me

@kkoomen
Copy link
Owner

kkoomen commented May 2, 2023

@ozwaldorf Hi. You are right that the support is very poor, because this is simply my own personal project that I open sourced. I only use a wacom drawing tablet when using this, maybe a touchpad or mouse, but that happens rarely, and to clarify, I haven't planned on adding support for anything else than a PC/laptop. Maybe in the future.

That being said, I just added basic touch support for you, you should be able to draw right now. Let me know if it works as you expect and what you are missing that would like to be added. If you are quick in responding I can immediately work on it, because I have all the time this week to work on the project.

@kkoomen kkoomen self-assigned this May 2, 2023
@kkoomen kkoomen added the enhancement New feature or request label May 2, 2023
@ozwaldorf
Copy link
Author

Thanks for the fast response. I'm able to draw successfully with the latest commits, although it still has a side effect of zooming in and out while touching

@kkoomen
Copy link
Owner

kkoomen commented May 3, 2023

@ozwaldorf Alright, I guess you want a two-finger pinch zoom to zoom in/out, right?

EDIT: @ozwaldorf I just created pinch touch support inside the master branch. Please have a look and see if zooming in/out with two fingers works as expected and let me know. I don't have touch devices, so I somewhat simulated it. Hope it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants