Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom / Default icons needed #627

Closed
rthawkcom opened this issue Jul 27, 2023 · 2 comments
Closed

Custom / Default icons needed #627

rthawkcom opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@rthawkcom
Copy link

Not all the .zim archive files include a default icon. Also, it would be nice to override existing default icons with custom made icons. I would suggest having the application check for the presence of a picture file, by the same name as the .zim archive, and if present, use that in place of the missing or default icon.

@kelson42
Copy link
Contributor

@rthawkcom AFAIK you can do that if you put the favicon in the library.xml. The kiwix-manage does not allow to do that, but this should work like you expect in kiwix-serve.

@kelson42 kelson42 self-assigned this Jul 27, 2023
@kelson42 kelson42 added this to the 3.6.0 milestone Jul 27, 2023
@kelson42
Copy link
Contributor

Having a favicon is clearly now a requirement.

But related to kiwix/libkiwix#989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants