-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test if JQuery can be fully removed by upgrading Bootstrap #1233
Comments
Before jumping in I'd like to know if I am right or wrong. |
Actually, for this issue, you just need to update Bootstrap to a version that doesn't rely on JQuery and remove any mention of JQuery from It might be necessary to adapt some of our Bootstrap classes in If necessary, you might need some guidance on how to make sure the bootsrap dependency is rewritten by Babel (in |
Let me know if you want to try. Take a look at CONTRIBUTING.md in this Repo to get started (read it carefully all the way through -- there are some gotchas!). |
Ya sure I would love to give it a shot! Thanks for such a descriptive response and sharing the CONTRIBUTING.md file I'll read it carefully as well ! |
Usually I start working on a issue directly but as per CONTRIBUTING guide I should ask you to assign me the issue. |
Hey @Jaifroid ! Can i work on this issue ,for that So for this issue this will be my approach
Will this approach would work? |
Hey @Jaifroid ! Shall i go ahead and work on this issue with the approach i gave above? Thanks |
@THEBOSS0369 I just need to check that @AritraLeo doesn't want to finish his PR which was actually already very close to solving this issue, but wasn't passing tests, so let's wait a few more days. |
I have now removed all JQuery from Kiwix JS code, but as mentioned in #1225 and #367, our version of Bootstrap still requires it, so we still have to load it.
We need to test whether we can upgrade Bootstrap to the next version that no longer uses JQuery, while still keeping backward compatibility with IE11+, Firefox OS, etc. It's possible that Babel can provide that compatibility, even if the Bootstrap library doesn't support older browsers any more (which I believe is the case). It needs testing.
The text was updated successfully, but these errors were encountered: