Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of FSA API and webkitdirectory stores unnecessary keys in localStorage and webkitdirectory fails to clear when new directory is loaded #1220

Closed
Jaifroid opened this issue Mar 2, 2024 · 1 comment · Fixed by #1219
Closed

Use of FSA API and webkitdirectory stores unnecessary keys in localStorage and webkitdirectory fails to clear when new directory is loaded #1220

Jaifroid opened this issue Mar 2, 2024 · 1 comment · Fixed by #1219
Assignees
@Jaifroid
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix cleanup user interface
Milestone
v4.1

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Mar 2, 2024 •
edited
Loading

Additionally, when a user picks a new directory using webkitdirectory API, the old contents are not cleared from the list, and the new contents are, confusingly, added to the dropdown list of archives.

Originally posted by @Jaifroid in #1156 (comment)

Furthermore, subdirectory names and all their contents, regardless of whether they are ZIM archives or not, get stored in the kiwixjs-zimFilenames key in localStorage.
@Jaifroid Jaifroid self-assigned this Mar 2, 2024
@Jaifroid Jaifroid added cleanup user interface bug-non-critical For bugs that it would be nice to fix rather than critical to fix labels Mar 2, 2024
@Jaifroid Jaifroid added this to the v4.1 milestone Mar 2, 2024
@Jaifroid Jaifroid changed the title Use of webkitdirectory stores unnecessary keys in localStorage and fails to clear when new directory is loaded Use of FSA API and webkitdirectory stores unnecessary keys in localStorage and webkitdirectory fails to clear when new directory is loaded Mar 2, 2024
@Jaifroid
Copy link
Member Author

Jaifroid commented Mar 2, 2024

Storage of unnecessary keys also affects use of File System Access API when picking a directory.

@Jaifroid Jaifroid mentioned this issue Mar 2, 2024
Merged
Jaifroid added a commit that referenced this issue Mar 2, 2024
@Jaifroid
Fix errors enumerating ZIM archives in directory #1220 (#1219)
7c65c58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix cleanup user interface
Projects
None yet
Milestone
v4.1
Development

Successfully merging a pull request may close this issue.

Fix errors enumerating ZIM archives in directory kiwix/kiwix-js
1 participant
@Jaifroid