Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support srcset in jQuery mode #1175

Closed
Jaifroid opened this issue Dec 2, 2023 · 0 comments · Fixed by #1181
Closed

Support srcset in jQuery mode #1175

Jaifroid opened this issue Dec 2, 2023 · 0 comments · Fixed by #1181
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix not-main-usage zimit Code relating to the support of Zimit-style archives

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Dec 2, 2023

In providing fallback support for Zimit reading, I realize that we don't extract images in srcset in jQuery mode. Although we are not developing for jQuery mode any more, this seems like an easy addition to the current method for decoding images in jQeury mode (function loadImagesJquery());

A test case, after #1173 is merged, would be the Zimit-based birdsofladakh ZIM.
@Jaifroid Jaifroid added not-main-usage bug-non-critical For bugs that it would be nice to fix rather than critical to fix zimit Code relating to the support of Zimit-style archives labels Dec 2, 2023
@Jaifroid Jaifroid linked a pull request Dec 10, 2023 that will close this issue
Refactor zimit processing #1181
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix not-main-usage zimit Code relating to the support of Zimit-style archives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor zimit processing kiwix/kiwix-js
1 participant
@Jaifroid