Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "flaky" unit tests #1071

Open
BPerlakiH opened this issue Jan 6, 2025 · 1 comment · May be fixed by #1072
Open

Fix "flaky" unit tests #1071

BPerlakiH opened this issue Jan 6, 2025 · 1 comment · May be fixed by #1072
Assignees
Milestone

Comments

@BPerlakiH
Copy link
Collaborator

After double checking our build issues, I realised that some unit-test results, are heavily dependent on User Defaults, which is a key/value storage by Apple, which is persisted across sessions.
By running the same Unit-tests several times (repeatedly without building) some of them might fail.

Proposed solution:

  • Wrap our user-default calls for those failing tests
  • Use a test instance instead, that won't persist the results
  • Also make sure that the created test db entries are cleaned-up properly
@BPerlakiH BPerlakiH self-assigned this Jan 6, 2025
@BPerlakiH BPerlakiH added this to the 3.7.1 milestone Jan 6, 2025
@BPerlakiH BPerlakiH linked a pull request Jan 6, 2025 that will close this issue
@kelson42
Copy link
Contributor

kelson42 commented Jan 7, 2025

This does impact only the devs IMHO, portponing.

@kelson42 kelson42 modified the milestones: 3.7.1, 3.8.0 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants