Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inline title for Kiwix in sidebar #1069

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1060

Simulator Screenshot - iPad mini (A17 Pro) - 2025-01-05 at 20 32 51

iPhone and macOS are not affected.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.20%. Comparing base (0a9d126) to head (80bfaed).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
App/SidebarViewController.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1069       +/-   ##
===========================================
+ Coverage   25.02%   36.20%   +11.18%     
===========================================
  Files         124      129        +5     
  Lines        7017     7543      +526     
===========================================
+ Hits         1756     2731      +975     
+ Misses       5261     4812      -449     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42
Copy link
Contributor

kelson42 commented Jan 6, 2025

I would liketo release next patch release before merging this.

@kelson42 kelson42 force-pushed the update-kiwix-title-in-sidebar branch from 13341b0 to c6863d5 Compare January 17, 2025 17:08
@kelson42
Copy link
Contributor

@BPerlakiH CI does not pass

@kelson42 kelson42 force-pushed the update-kiwix-title-in-sidebar branch from c6863d5 to 80bfaed Compare January 20, 2025 05:05
@kelson42 kelson42 merged commit d2c9f14 into main Jan 20, 2025
4 checks passed
@kelson42 kelson42 deleted the update-kiwix-title-in-sidebar branch January 20, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar title "Kiwix" should be better positioned
4 participants