Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Live Activities for Download % and/or speed (MB/s) #1037

Open
plyght opened this issue Nov 27, 2024 · 10 comments · May be fixed by #1058
Open

Add Live Activities for Download % and/or speed (MB/s) #1037

plyght opened this issue Nov 27, 2024 · 10 comments · May be fixed by #1058
Assignees
@plyght
Labels
enhancement
Milestone
3.8.0

Comments

@plyght
Copy link

plyght commented Nov 27, 2024

Exactly what the title says; Add live activities support for iOS to display download progress (speed and percentage completed) on the lock screen and in the Dynamic Island. This would provide real-time updates without needing to open the app.
@kelson42
Copy link
Contributor

@rgaudin @BPerlakiH Clear for you what is requested?

@rgaudin
Copy link
Member

rgaudin commented Nov 27, 2024

It's a sort of system notification that stays active for live activities so the user can peak at progress without re-entering the app. It's common for sports app for instance.

@BPerlakiH
Copy link
Collaborator

Yes it is clear for me, we are talking about this Apple feature: https://developer.apple.com/design/human-interface-guidelines/live-activities

@kelson42 kelson42 added this to the 3.7.0 milestone Nov 27, 2024
@kelson42
Copy link
Contributor

Announce: If you think this wiuld be a nice improvement, please vote.

@kelson42 kelson42 modified the milestones: 3.7.0, 3.8.0 Dec 12, 2024
@kelson42
Copy link
Contributor

The idea of implement Activities for downloads is validated

@kelson42 kelson42 removed the question label Dec 15, 2024
@plyght
Copy link
Author

plyght commented Dec 21, 2024

@kelson42 @BPerlakiH Any updates on this?

@kelson42
Copy link
Contributor

@plyght The idea is validated, you want to implement it?

@plyght
Copy link
Author

plyght commented Dec 21, 2024

@kelson42 Do you mean coding the implementation myself or overseeing the feature’s development?

@kelson42
Copy link
Contributor

@plyght Yes, I mean you making a PR to implement the feature.

plyght added a commit to plyght/kiwix-apple that referenced this issue Dec 21, 2024
@plyght
Add live activities for download progress
52cf609 
Fixes kiwix#1037

Add Live Activities support for displaying download progress on the lock screen and in the Dynamic Island.

* Import `ActivityKit` and create a new `DownloadActivityAttributes` struct in `App/App_iOS.swift`.
* Update `Model/DownloadService.swift` to manage Live Activities during download progress changes.
* Modify `Views/BuildingBlocks/DownloadTaskCell.swift` to include Live Activities updates.
* Update `Views/Library/ZimFileDetail.swift` to handle Live Activities for download details.
* Add Live Activities updates in `Views/Library/ZimFilesDownloads.swift`.
* Add a new setting to enable or disable Live Activities in `Views/Settings/Settings.swift`.
* Handle alerts for Live Activities in `Views/ViewModifiers/AlertHandler.swift`.
* Add `Model/DownloadActivityAttributes.swift` to define the attributes for Live Activities.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/kiwix/kiwix-apple/issues/1037?shareId=XXXX-XXXX-XXXX-XXXX).
@plyght plyght linked a pull request Dec 21, 2024 that will close this issue
Open
@plyght
Copy link
Author

plyght commented Dec 21, 2024

@kelson42 see #1058

@kelson42 kelson42 assigned plyght and unassigned BPerlakiH Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plyght plyght

Labels
enhancement
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Add live activities for download progress plyght/kiwix-apple
4 participants
@rgaudin @kelson42 @BPerlakiH @plyght