Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CD for macOS #1074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CD for macOS #1074

wants to merge 1 commit into from

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1055

Fix the CD process for macOS.
In short: the in-app-purchase is not supported by Developer ID signed apps (outside of the App Store), therefore we cannot use that capability in the FTP macOS build.
Although Apple Pay itself is supported, the In App Purchase capability that we use (for Donation - a purchase of a non-digital good) is not supported.

The found Apple reference:
https://developer.apple.com/help/account/reference/supported-capabilities-macos

We need a follow up discussion, if we want to hide the support button in this case or maybe use a direct link instead (since this build is not going to be verified by Apple).

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.86%. Comparing base (58f7577) to head (1c0e568).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   35.87%   36.86%   +0.98%     
==========================================
  Files         127      127              
  Lines        7492     7492              
==========================================
+ Hits         2688     2762      +74     
+ Misses       4804     4730      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Contributor

We need a follow up discussion, if we want to hide the support button in this case or maybe use a direct link instead (since this build is not going to be verified by Apple).

@BPerlakiH Please open an issue for that asap, otherwise we will forget

@kelson42
Copy link
Contributor

kelson42 commented Jan 10, 2025

We need a follow up discussion, if we want to hide the support button in this case or maybe use a direct link instead (since this build is not going to be verified by Apple).

@BPerlakiH Please open an issue for that asap, otherwise we will forget

Actually, if the feature is not working, it has to be hidden. You can do that here in this PR. you should detect the way the app is compiled and act accordingly.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please rename the PR to something more meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS FTP release signing fails
4 participants