Reintroduced the Fetch Library for Downloading ZIM files. #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the DownloadManager from our project. * Refactored the code, and test cases to use the Fetch library.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4143 +/- ##
============================================
- Coverage 57.73% 56.77% -0.96%
- Complexity 1496 1516 +20
============================================
Files 313 312 -1
Lines 13324 13285 -39
Branches 1707 1644 -63
============================================
- Hits 7692 7542 -150
- Misses 4507 4612 +105
- Partials 1125 1131 +6 ☔ View full report in Codecov by Sentry. |
…ifications to open the ZIM file then same ZIM file is opening for both notifications.
* Introduced the DownloadMonitorService to keep alive the fetch instance so that the downloading works in the background as well as on app kill.
|
@MohitMaliFtechiz Let me know when this is ready to merge Would be great to confirm also that scenarios fixed in 2.13.0 are still fixed. |
* Upgraded Fetch to 3.4.1. * Upgraded Kotlin kotlin-stdlib from JDK7 to JDK8. * Upgraded Kotlin version to 2.0.0 to support the latest Fetch library. * Upgraded Dagger to 2.53.1. * Upgraded ObjectBox to 4.0.3. * Notification now shows "Pause" and "Resume" buttons instead of "pause" and "resume". * Fixed: Notification buttons were not working on Android 13 and above. * Fixed: Downloading was not working in the background. Added a foreground service for Fetch so that downloading will continue in the background.
This was referenced Dec 23, 2024
…ification while the application was not running in the background.
|
@kelson42 This PR is ready for review.
The previous fixes are working fine with these changes. |
|
@MohitMaliFtechiz This is great, will wait feedbacka from users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4140
Fixes #4138
Fixes #4106
3.4.1.kotlin-stdlibfrom JDK7 to JDK8.2.0.0to support the latest Fetch library.2.53.1.4.0.3.