Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest similarly spelled search results #41

Open
mhutti1 opened this issue Mar 18, 2017 · 12 comments
Open

Suggest similarly spelled search results #41

mhutti1 opened this issue Mar 18, 2017 · 12 comments
Assignees
Milestone

Comments

@mhutti1
Copy link
Contributor

mhutti1 commented Mar 18, 2017

From @rashiq on June 8, 2016 13:6

Reported by rauldelacalle on 2015-03-09 01:16 UTC
SPANISH;

Buen día.

Descargue la aplicacion Kiwix para android y la instalé. Descargué el Wikcionario en español, lo descomprimí y lo cargue en la memoria externa del telefono inteligente. Desde la aplicación leo el archivo y todo está bien.

Pero cuando escribo una palabra de manera equivocada el Wikcionario no me corrige. Ejemplo: en español la forma correcta es: Zapato. Si escribo sapato la aplicación me dice: Error: "falló la carga del artículo sapato", pero no me corrige debería mostrame las opciones. Es decir que tengo que ser un experto en el idioma para buscar, no me sirve de esa manera pues el objetivo es que me corrija cuando yo estoy equivocado.

Si hago lo mismo en el computador me muestra como opciones:

  1. Zapato
  2. Calzado
  3. Pasta de zapatos
  • Es posible mejorar la aplicación para android?
  • Estoy fallando en algo?

ENGLISH:

Good day.

Download the Kiwix application for android and I installed it. I downloaded the Wiktionary in Spanish, unzipped it and upload it to the external memory of the smart phone. Since I read the application file and all is well.

But when I write the wrong word Wiktionary does not correct me. Example: in Spanish is written: ZAPATO. If SAPATO write the application tells me: Error: "failed load SAPATO article", but does not correct me should show me the options. You mean I have to be an expert in the language to find, does not help me that way because the objective is to correct me when I'm wrong.

If I do the same on the computer shows me as options:

  1. Zapato
  2. Calzado
  3. Pasta de zapatos
  • It is possible to improve the application for android?
  • I'm failing at something?

Copied from original issue: kiwix/kiwix-xulrunner#193

@mhutti1
Copy link
Contributor Author

mhutti1 commented Mar 18, 2017

From @rashiq on June 8, 2016 13:14

Updated by kelson42 on 2015-06-23 04:55 UTC

  • labels: --> android
  • Group: v1.0 --> None

@mhutti1
Copy link
Contributor Author

mhutti1 commented Mar 18, 2017

This appears to be a search limitation. @kelson42 what is the desktop version do, that the app doesn't that makes search more intelligent?

@mhutti1
Copy link
Contributor Author

mhutti1 commented Mar 18, 2017

From @Frenzie on March 2, 2017 14:32

For search query results it would be nice to make them ignore case, diacritics, and possibly punctuation (except that the matches closest to what you typed should come higher in the results list). Especially on a phone it's much easier to type deja vu or deja-vu than déjà-vu. Basically like Aard Dictionary.

@dr0pdb
Copy link
Contributor

dr0pdb commented Feb 14, 2018

@mhutti1 I'll give it a shot!

@kelson42
Copy link
Collaborator

Probably something which needs to be delegated to the kiwix-lib/Xapian. I strongly suspect there is nothing much we should do on Java side.

@rashiq
Copy link
Contributor

rashiq commented Mar 20, 2018

We could probably play around with levenshtein distance, if we want to have something really rudimentary on the java side

@kelson42
Copy link
Collaborator

kelson42 commented Mar 20, 2018

All of this should be done in the kiwix-lib anyway. The libzim has already a Levenshtein distance implementation. We shoudl probably check if the ticket is still valid, a lot of things has been improved meanwhile on the search.

@kelson42 kelson42 self-assigned this Mar 20, 2018
@kelson42
Copy link
Collaborator

Will generate a new WPES ZIM file and check this again.

@rashiq
Copy link
Contributor

rashiq commented Mar 20, 2018

Gotcha

@Frenzie
Copy link

Frenzie commented Mar 20, 2018

@kelson42 The latest Kiwix for Android on F-Droid and Google Play (2.2) is from almost exactly one year ago, 2017-03-21, so unsurprisingly when you type deja vu it doesn't find déjà-vu.

Is there some kind of nightly build easily available to test with or would one have to build it?

@stale
Copy link

stale bot commented Jun 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2019
@kelson42
Copy link
Collaborator

kelson42 commented Nov 1, 2022

All the problems around diacritics or case should be fixed, but we still don’t have a solution to propose similar words. This is wha this tickets depends on openzim/libzim#731

@kelson42 kelson42 added this to the 3.14.0 milestone Sep 6, 2024
@stale stale bot removed the stale label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants