Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Matomo logo/favicon in git #81

Open
kelson42 opened this issue Jun 1, 2019 · 5 comments
Open

Put Matomo logo/favicon in git #81

kelson42 opened this issue Jun 1, 2019 · 5 comments
Assignees

Comments

@kelson42
Copy link
Contributor

kelson42 commented Jun 1, 2019

No description provided.

@kelson42 kelson42 self-assigned this Jun 1, 2019
@stale
Copy link

stale bot commented Jul 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 31, 2019
@rgaudin
Copy link
Member

rgaudin commented Apr 14, 2022

There is no explanation on the why of this here. Currently, beside the DB, we have the following files on disk:

  • branding: the logo and favicon mentioned here.
  • the config file that can easily be moved to k8s and mounted
  • the webroot which is the matomo source code that the image copies on start if not present. I believe the tmp/ subfolder that's full of cache stuff is ephemeral stuff that doesn't need to be stored. We could probably save this volume as well.

Now I don't understand exactly what “in git” means. If it means “in the image”, it's not worth having a custom image just for that.
We could store them in k8s and mount them but they'd become read-only, thus preventing this feature from working.

Let me know

@stale stale bot removed the stale label Apr 14, 2022
@kelson42 kelson42 assigned rgaudin and unassigned kelson42 May 21, 2022
@kelson42
Copy link
Contributor Author

@rgaudin It seems the logo has vanished at all now. Would you be able to bring it back?

@rgaudin
Copy link
Member

rgaudin commented May 21, 2022

Fixed ; sorry 😅 kiwix/operations@7cd9c2e

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants