httpGet does not render parameters correctly

[vojkny]

Bug Report

Description

Looking at the docs at https://github.com/kittinunf/fuel/blob/master/fuel/README.md:

Fuel.get("https://httpbin.org/get", listOf("foo" to "foo", "bar" to "bar"))
    .url
// https://httpbin.org/get?foo=foo&bar=bar

However as far as I can see on Fuel of version 2.3.1, the parameters are dropped and the result is:

https://httpbin.org/get

Development Machine

• OS: Mac
• Fuel version: 2.3.1
• Kotlin version: 1.6.10
• JDK 17

[vojkny]

🙏

[yshrsmz]

https://github.com/kittinunf/fuel/blob/2.3.1/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/requests/DefaultRequest.kt#L36

url is a constructor parameter of DefaultRequest, and parameters is another constructor parameter, so, that behavior kind of makes sense.

We need a method to combine those two (and other necessary fields)

[kittinunf]

I think we should move over to 3.x at this point. 2.x is end of life.

[yshrsmz]

True. Just wanted to add more detail to the issue.