Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IDNA 2008 (RFC 5891) when encoding URL (#819) #821

Closed
wants to merge 1 commit into from
Closed

Add support for IDNA 2008 (RFC 5891) when encoding URL (#819) #821

wants to merge 1 commit into from

Conversation

j-bernard
Copy link

@j-bernard j-bernard commented Nov 29, 2021 •
edited
Loading

Description

Convert URL host to A-Label before making a request.
IDNA object is provided by ICU4j dependency for JVM but on Android it is included in android.icu.text.IDNA so you may want to handle it differently for Android which I did not do.

Fixes #819

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@kittinunf
Copy link
Owner

Thanks for the PR, let me try to find out what's wrong with the travis CI, maybe we probably need to move over to Github action instead.

@kittinunf kittinunf deleted the branch kittinunf:master December 11, 2022 14:05
@kittinunf kittinunf closed this Dec 11, 2022
@arnt
Copy link

arnt commented Jun 20, 2023

Hi,

why was this closed? It looks quite nifty.

@arnt
Copy link

arnt commented Jun 20, 2023

Oh, it's not necessary. Fuel uses OkHttp, which added IDNA2008 support a month or two ago. Fuel should then not need anything itself, AIUI. Agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for IDNA 2008 (RFC 5891)
3 participants
@j-bernard @kittinunf @arnt