-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IDNA 2008 (RFC 5891) #819
Comments
Thanks for filing the issue! Do you think you can try to take a stab and open a PR to support this? Otherwise, I can try to see how to fix this later at the end of the week or something. |
I'll try to spend some time on it, maybe next week. |
j-bernard
added a commit
to j-bernard/fuel
that referenced
this issue
Nov 29, 2021
j-bernard
added a commit
to j-bernard/fuel
that referenced
this issue
Nov 29, 2021
j-bernard
added a commit
to j-bernard/fuel
that referenced
this issue
Nov 29, 2021
j-bernard
added a commit
to j-bernard/fuel
that referenced
this issue
Nov 29, 2021
j-bernard
added a commit
to j-bernard/fuel
that referenced
this issue
Nov 29, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The tests have been conducted on Android SDK 30 with Fuel version 2.3.1.
With Fuel, URLs containing Unicode characters are converted using percent encoding but domain names should be converted as defined in RFC 5891.
On Android, the stack does it jobs and correctly performs IDNA conversion, replacing the percent encoding, but it follows an old standard IDNA 2003 (RFC 3490).
To be fully compliant, fuel should perform domain name conversion following IDNA 2008 standard.
This snippet does the conversion from U-label to A-label which is the form that should be provided to the network stack:
The text was updated successfully, but these errors were encountered: