Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will panic on newer rust due to signal_simple's use of mem::uninitialized #3

Open
5225225 opened this issue Aug 1, 2022 · 0 comments

Comments

@5225225
Copy link

5225225 commented Aug 1, 2022

Hello! In rust-lang/rust#99389 we're making the checks for mem::uninitialized stronger, and this crate runs into those, through the use of signal_simple.

I have reported it upstream, kitsuneninetails/signal-rust#4, but it might be best to instead use a different signal crate.

For reference, the backtrace is

thread 'tests::test_term' panicked at 'attempted to leave type `libc::unix::linux_like::linux::gnu::b64::x86_64::sigaction` uninitialized, which is invalid', /home/jess/.cargo/registry/src/github.com-1ecc6299db9ec823/signal-simple-0.1.1/src/signal.rs:19:29
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic
   3: core::mem::uninitialized
             at /home/jess/src/rust/library/core/src/mem/mod.rs:685:9
   4: signal_simple::signal::signal_internal
             at /home/jess/.cargo/registry/src/github.com-1ecc6299db9ec823/signal-simple-0.1.1/src/signal.rs:19:29
   5: signal_simple::signal::signal
             at /home/jess/.cargo/registry/src/github.com-1ecc6299db9ec823/signal-simple-0.1.1/src/signal.rs:11:5
   6: term_handler::wait_for_term
             at ./src/lib.rs:16:5
   7: term_handler::tests::test_term
             at ./src/lib.rs:33:9
   8: term_handler::tests::test_term::{{closure}}
             at ./src/lib.rs:28:5
   9: core::ops::function::FnOnce::call_once
             at /home/jess/src/rust/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    tests::test_term
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant