You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your PatchSageAttention is not a normal model patch - if the user bypasses/mutes/bypasses it that won't disable the effect. You should warn the user so they don't accidentally leave it enabled. Tooltips/description in the node itself and a section in the README would be a good idea. This is the approach I took in my own nodes: https://github.com/blepping/ComfyUI-bleh#blehglobalsageattention
It's better to use something like a sampler wrapper for that kind of thing because that way it can safely be reverted with a context manager or try/finally block.
The text was updated successfully, but these errors were encountered:
Yeah that's true, it's mostly been an experimental node, I did look at yours at one point, but also wanted to try the different 2.0.0 modes to see if they make a difference. I'm very much not well versed in the patching system so this is what it is, you're right about the warning though and that should definitely be there.
Your PatchSageAttention is not a normal model patch - if the user bypasses/mutes/bypasses it that won't disable the effect. You should warn the user so they don't accidentally leave it enabled. Tooltips/description in the node itself and a section in the README would be a good idea. This is the approach I took in my own nodes: https://github.com/blepping/ComfyUI-bleh#blehglobalsageattention
It's better to use something like a sampler wrapper for that kind of thing because that way it can safely be reverted with a context manager or try/finally block.
The text was updated successfully, but these errors were encountered: