Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for xarray 2024.10.0 #145

Open
khaeru opened this issue Oct 29, 2024 · 0 comments
Open

Update for xarray 2024.10.0 #145

khaeru opened this issue Oct 29, 2024 · 0 comments
Assignees

Comments

@khaeru
Copy link
Owner

khaeru commented Oct 29, 2024

Nightly tests began to fail with the release of xarray 2024.10.0, e.g. here

The failing tests are:

genno/tests/core/test_quantity.py::TestQuantity::test_sel_xarray[sparsedataarray] - TypeError: Vectorized indexing is not supported
genno/tests/test_operator.py::test_select1[sparsedataarray] - TypeError: Vectorized indexing is not supported

both via:

genno/core/sparsedataarray.py:274: in sel
    .sel(indexers=indexers, method=method, tolerance=tolerance, drop=drop)

This appears to be pydata/xarray#9694.

For mitigation:

  • SparseDataArray is not the default genno.Quantity class currently. If using AttrSeries (the default), genno remains usable.
  • If using SparseDataArray, use xarray < 2024.10.0.

To resolve:

  • Track resolution of the upstream issue.
  • Make any adjustments necessary in genno itself.
khaeru added a commit that referenced this issue Oct 29, 2024
- Add .testing.MARK for reusable marks.
khaeru added a commit that referenced this issue Oct 29, 2024
- Add .testing.MARK for reusable marks.
@khaeru khaeru self-assigned this Oct 29, 2024
khaeru added a commit that referenced this issue Nov 26, 2024
Still present in xarray 2024.11.0.
khaeru added a commit that referenced this issue Nov 26, 2024
Still present in xarray 2024.11.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant