Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of painFormat in the SepaDocument constructor #114

Open
lippertto opened this issue Nov 18, 2024 · 1 comment
Open

Validation of painFormat in the SepaDocument constructor #114

lippertto opened this issue Nov 18, 2024 · 1 comment

Comments

@lippertto
Copy link
Contributor

I have updated sepa.js to 2.0.0, and I ran into a problem because the pain format that I used was no longer supported.
The root node of the generated xml document was called undefined which is obviously not correct.

I would create a PR to check if the provided painFormat is supported in the constructor and throw an exception if it's not.
Do you think this makes sense?

@kewisch
Copy link
Owner

kewisch commented Jan 5, 2025

Makes sense to me! Note I just committed to accepting a typescript rewrite in #70, though this was just moments ago. We should make sure it survives the rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants