Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with SVG Font Awesome kits #49

Open
alahmnat opened this issue Sep 17, 2022 · 0 comments
Open

Does not work with SVG Font Awesome kits #49

alahmnat opened this issue Sep 17, 2022 · 0 comments

Comments

@alahmnat
Copy link

If the official Font Awesome plugin is installed and set to use a kit, and that kit is set to use SVGs, the javascript for this plugin can't update the field in wp-admin to reflect the selected star rating. This is because when a kit uses SVGs, it comments out the <i> tags, causing the JS to fail to iterate over the collection. The value will still be set and saved properly, there's just no visual indication that anything changed. If the kit is set to use Webfonts, everything behaves as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant