Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required field #43

Open
karlsan opened this issue May 19, 2021 · 2 comments
Open

Required field #43

karlsan opened this issue May 19, 2021 · 2 comments

Comments

@karlsan
Copy link

karlsan commented May 19, 2021

Recently implemented this in a project, great stuff!

I'm using it in a WP comment form, together with other ACF custom fields. These fields are all required and when trying to send the form with empty fields, standard ACF fields get a small popup with "Fill out this field". The stars are also required, but when sending the form, it goes to a new page with the error message "Please enter a value clicking on stars form 1 to 5".

By this point the form has already submitted the comment though. When going back to the form page in the browser and selecting stars, then trying to post the comment again, it says a similar comment has already been posted. Which means the saved comment doesn't have most form data.

Would it be possible to do the required field check on the form page, like ACF, instead of a separate page?

Ps. There also seems to be a typing error in the "..clicking on stars form.." above (form instead of from). This is from line #287 in StarRatingField.php

@bluantinoo
Copy link
Contributor

@karlsan I cannot reproduce this error, but actually once in a while I find a comment without rating... even if the field is required... are you using ACF or ACF Pro? on wich browser it happen?

@karlsan
Copy link
Author

karlsan commented Mar 23, 2023

Hi @bluantinoo, unfortunately it was some time since I worked on the project so I can't check now, but I think we were using ACF Pro and it wasn't browser specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants