Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter functionality improvements #10

Open
undefined-box opened this issue Oct 16, 2022 · 1 comment
Open

Filter functionality improvements #10

undefined-box opened this issue Oct 16, 2022 · 1 comment
Assignees

Comments

@undefined-box
Copy link

The search filter currently makes a new parameterized call to the API via the cryptocurrency id, causing this issues:

  • Unnecessary API calls:
    the application already fetches all results, it should not be necessary to make a new call upon search if the intent is to filter them

  • Can display only one result:
    The user must specify the exact id of the cryptocurrency to be recovered, so the filter cannot show more than one result at a time

This could be fixed by storing the total results in the app state and displaying filtered results if needed; since the data is managed locally, the application can easily manipulate it, for example allowing the user to show all results that contain a given substring.

I can submit a PR if this looks ok for you :)

@kepoCode
Copy link
Owner

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants