You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The search filter currently makes a new parameterized call to the API via the cryptocurrency id, causing this issues:
Unnecessary API calls:
the application already fetches all results, it should not be necessary to make a new call upon search if the intent is to filter them
Can display only one result:
The user must specify the exact id of the cryptocurrency to be recovered, so the filter cannot show more than one result at a time
This could be fixed by storing the total results in the app state and displaying filtered results if needed; since the data is managed locally, the application can easily manipulate it, for example allowing the user to show all results that contain a given substring.
I can submit a PR if this looks ok for you :)
The text was updated successfully, but these errors were encountered:
The search filter currently makes a new parameterized call to the API via the cryptocurrency id, causing this issues:
Unnecessary API calls:
the application already fetches all results, it should not be necessary to make a new call upon search if the intent is to filter them
Can display only one result:
The user must specify the exact id of the cryptocurrency to be recovered, so the filter cannot show more than one result at a time
This could be fixed by storing the total results in the app state and displaying filtered results if needed; since the data is managed locally, the application can easily manipulate it, for example allowing the user to show all results that contain a given substring.
I can submit a PR if this looks ok for you :)
The text was updated successfully, but these errors were encountered: