Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add disable flag in Compare and CompareHeaders #4

Open
shivamsouravjha opened this issue Oct 15, 2024 · 6 comments
Open

feature: add disable flag in Compare and CompareHeaders #4

shivamsouravjha opened this issue Oct 15, 2024 · 6 comments
Assignees
@techmannih
Labels
bug Something isn't working duplicate This issue or pull request already exists golang good first issue Good for newcomers HACKTOBERFEST2024 hacktoberfest-accepted

Comments

@shivamsouravjha
Copy link
Collaborator

shivamsouravjha commented Oct 15, 2024 •
edited
Loading

  • Currently just CompareJson has disable color feature, ideally both Compare and CompareHeaders should also have this available.
@shivamsouravjha shivamsouravjha added bug Something isn't working duplicate This issue or pull request already exists good first issue Good for newcomers HACKTOBERFEST2024 hacktoberfest-accepted golang labels Oct 15, 2024
@techmannih
Copy link

@shivamsouravjha May I work on this issue!

@shivamsouravjha
Copy link
Collaborator Author

sure @techmannih !

@techmannih
Copy link

Thank you @shivamsouravjha

@techmannih
Copy link

  • Currently just CompareJson has disable color feature, ideally both Compare and CompareJSON should also have this available.

you have given in title: add disable flag in Compare and CompareHeaders, but in description: Compare and CompareJSON

@shivamsouravjha
Copy link
Collaborator Author

have updated the same @techmannih CompareHeaders should have bool flag as well. also ensure adding unit test cases for this

@techmannih
Copy link

Yes, Sir. Got it!

@akshat99812 akshat99812 mentioned this issue Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techmannih techmannih

Labels
bug Something isn't working duplicate This issue or pull request already exists golang good first issue Good for newcomers HACKTOBERFEST2024 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shivamsouravjha @techmannih