-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If infinite loop is set to false, all slides have "aria-hidden" set to true #1408
Comments
Looks like its a bug with center mode. I tried disabling that and it worked. http://codepen.io/gwst/pen/dovNVg If you need to use center mode and want to hack proper aria function until this get's fixed, I think you can get it done by using the beforeChange event to toggle the attribute. More here |
Hi thanks for your reply and for the hack until there's a fix. Just to point out, if I remove the "infinite" attribute from my initial above example, but leave centerMode set to "true", everything works as expected, so not sure if the issue is with infinite or center mode EDIT: after playing about some more I see you are right that it is an issue with center mode. Thanks. |
Also having this issue on v1.5.0 |
Any updates here? I am having this same issue. |
I'm having the same issue. This is a critical bug as far as accessibility is concerned. It's like if the whole carousel wasn't present. |
@esr360 @leggomuhgreggo I think the issue appears when you use both centerMode:true and infinite:false I worked around this in my local branch FOR MY PARTICULAR USE CASE. In All I did was copy everything within My use case is these particular settings arrows: true, and I am sure that this hack does not universally fix this issue but I didn't have time to deep dive into this chunk of logic and see exactly what was going on, and what would need to be different for infinite mode on/off. But I am pretty sure this bug is a result of not having a flow for Is @kenwheeler still accepting PR's? Looks like this project has been quiet for a while. If so, I will volunteer some time to do more extensive study and try to fix this for real. |
I've opened PR #4307 for this. I copied the logic as suggested by @underclockeddev and adjusted the code to remove what I think was needed for the infinite loop to render correctly. Hopefully this addresses the bug. |
If I set the "infinite" property to "false", the "aria-hidden" attribute on every slide seems to be set to true, when naturally the visible slides should be set to false.
http://codepen.io/esr360/pen/XbMpKg
The text was updated successfully, but these errors were encountered: