Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: lite bins - style_tab for compartments is broken - single tab is always left #255

Open
derFliegendeHamburger opened this issue Nov 26, 2024 · 2 comments

Comments

@derFliegendeHamburger
Copy link

with current code (@ 285 commits) for lite bins the style_tab for bins with compartments is broken - if any, then only onesingle tab is crated, always positioned at top left.

This same feature works well with the code version on printables (but that is too old to contain the new easy way for lite bins to define bottom height)

@derFliegendeHamburger
Copy link
Author

derFliegendeHamburger commented Nov 26, 2024

possilbe cause:
for style_tab=0; (all) in module cutEqual() the condition

        if (
            place_tab == 1 && (i != 1 || j != n_divy) // Top-Left Division
        ) {

is triggered for all but the top single compartment and thus calling cut() with t=5; thus preventing creation of a tab.

As I do not understand the intention of this conditional, I cannot offer a viable solution.
My primitve workaround is to replace invocation of cut(5) with cut(style_tab)

@derFliegendeHamburger
Copy link
Author

found likely culprit:
with Commit b4ff706 a new param place_tab was introduced to cutEqual(). Comment describes this:
'// place_tab: tab suppression for all compartments. see "gridfinity-rebuilt-bins.scad"'
But it was never implemented to set this new param place_tab to 0 when invoking from gridfinity-rebuilt-lite.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant