Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Support websockets #5

Open
amitsaha opened this issue Sep 8, 2016 · 4 comments
Open

[RFE] Support websockets #5

amitsaha opened this issue Sep 8, 2016 · 4 comments

Comments

@amitsaha
Copy link
Contributor

amitsaha commented Sep 8, 2016

Would you be interested in implementing support for web sockets? I can take a shot.

@sdogruyol
Copy link
Member

Not sure about how to test WebSockets. Why don't you take a shot 👍

@sdogruyol
Copy link
Member

This is a missing feature kemalcr/kemal#301

@vladfaust
Copy link

Have been just wondering around and I actually have an answer for this, @adamtrilling

  1. The server doesn't bind to a port in the TEST environment
  2. If you force it to do so, it blocks the entire process, so the test doesn't continue.
    Any ideas how to get around this? I suppose I could run the test and the server in two separate shells, but that won't work in CI.

You could possibly run the server in another Fiber as described here:

# ws_spec.cr

spawn do
  Kemal.run
end

sleep 1 # Give a time for the server to load up

test_websockets_and_their_responses

I may not be right, but anyway.

@zeratax
Copy link

zeratax commented Oct 22, 2020

any updates on this? I'm also stuck with this currently :/

specifically how I can simulate multiple clients connecting and talking with each other through my application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants