Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook enablement should be a CLI flag #64

Open
diranged opened this issue Dec 18, 2020 · 0 comments
Open

Webhook enablement should be a CLI flag #64

diranged opened this issue Dec 18, 2020 · 0 comments

Comments

@diranged
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Changing webhook.enabled from false to true seems like it needs to be a CLI argument that triggers a new deployment of the app.

What happened:

When you just switch the configmap from webhook.enabled: 'false' to webhook.enabled: 'true', the iam-manager reloads the configmap but it does not start listening on port 9443. However, it DOES create the registration with the API. This causes new requests for those resources to start failing. It seems like this should just be a CLI argument rather than a configmap setting because it fundamentally alters the way the code behaves and requires the code to begin listening on a new port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant