Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Resource Template #42

Open
VaibhavPage opened this issue Jan 24, 2020 · 2 comments
Open

Workflow Resource Template #42

VaibhavPage opened this issue Jan 24, 2020 · 2 comments

Comments

@VaibhavPage
Copy link

VaibhavPage commented Jan 24, 2020

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE REQUEST

What happened:
The Addon CR expects the Workflow template to be a string which leads to unnecessary confusion because it is difficult to debug issues related to resource indentation in the YAML string.

What you expected to happen:
Provide an option to define actual Workflow resource using unstructured.Unstructured.

Anything else we need to know?:
I have already done a similar feature in Argo-Events https://github.com/argoproj/argo-events/blob/master/pkg/apis/sensor/v1alpha1/types.go#L568

@VaibhavPage
Copy link
Author

@kevdowney I can add this feature if you are fine with it

@kevdowney
Copy link
Collaborator

@VaibhavPage Yes, please do add this, would be a great improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants