Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow annotation addonmgr.keikoproj.io/retry-count to trigger reconciling #252

Open
kevdowney opened this issue Jun 14, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kevdowney
Copy link
Collaborator

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE
What happened:
Sometimes users may want to retry an addon upgrade N number of times and adding some param in the spec can be done but it's less efficient then just having a specific annotation for this purpose.

What you expected to happen:
Add support to allow a specific annotation addonmgr.keikoproj.io/retry-count: 1 to trigger a reconcile, the count here should be >0 (positive) to be valid.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Addon Manager version
  • Kubernetes version :
$ kubectl version -o yaml

Other debugging information (if applicable):

  • Addon status:
$ kubectl describe addon <addon-name>
  • controller logs:
$ kubectl logs <addon-manager-pod>
@kevdowney kevdowney added good first issue Good for newcomers enhancement New feature or request labels Jun 14, 2023
@kevdowney kevdowney changed the title Allow annotation addonmgr.keikoproj.io/retry-count to trigger reconciling feat: Allow annotation addonmgr.keikoproj.io/retry-count to trigger reconciling Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant