-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeePassXC can't communicate with YubiKey (wrong serial) #10656
Comments
I've had this happen before in testing, but it was easily cleared by refreshing the key list. There is definitely a bug, need to hunt it down. |
If it's any help: most of the time the length of the wrong serial is correct, but sometimes the serial is reported as just the single number "4". |
I just went a bit through #10092. I found a mistake (we should pass productId not vendorId), not sure if related but worth to mention. keepassxc/src/gui/osutils/macutils/DeviceListenerMac.cpp Lines 56 to 57 in 1896883
|
Good catch! @phoerious |
* Fix #10656 - Add a small delay when before auto-polling hardware keys to all them to settle immediately after plugging in. This resolves an issue where the key's serial number could not be resolved due to hardware timeout. * Also fix use of uninitialized variable if polling serial number fails for whatever reason. * Fix typo in macOS key registration code * Prevent registering duplicate listeners on window focus. These were not de-registered because we didn't trigger on unfocus. Show/Hide are sufficient triggers to add and remove listeners.
* Fix #10656 - Add a small delay when before auto-polling hardware keys to all them to settle immediately after plugging in. This resolves an issue where the key's serial number could not be resolved due to hardware timeout. * Also fix use of uninitialized variable if polling serial number fails for whatever reason. * Fix typo in macOS key registration code * Prevent registering duplicate listeners on window focus. These were not de-registered because we didn't trigger on unfocus. Show/Hide are sufficient triggers to add and remove listeners.
* Fix #10656 - Add a small delay when before auto-polling hardware keys to all them to settle immediately after plugging in. This resolves an issue where the key's serial number could not be resolved due to hardware timeout. * Also fix use of uninitialized variable if polling serial number fails for whatever reason. * Fix typo in macOS key registration code * Prevent registering duplicate listeners on window focus. These were not de-registered because we didn't trigger on unfocus. Show/Hide are sufficient triggers to add and remove listeners.
* Fix #10656 - Add a small delay when before auto-polling hardware keys to all them to settle immediately after plugging in. This resolves an issue where the key's serial number could not be resolved due to hardware timeout. * Also fix use of uninitialized variable if polling serial number fails for whatever reason. * Fix typo in macOS key registration code * Prevent registering duplicate listeners on window focus. These were not de-registered because we didn't trigger on unfocus. Show/Hide are sufficient triggers to add and remove listeners.
* Fix #10656 - Add a small delay when before auto-polling hardware keys to all them to settle immediately after plugging in. This resolves an issue where the key's serial number could not be resolved due to hardware timeout. * Also fix use of uninitialized variable if polling serial number fails for whatever reason. * Fix typo in macOS key registration code * Prevent registering duplicate listeners on window focus. These were not de-registered because we didn't trigger on unfocus. Show/Hide are sufficient triggers to add and remove listeners.
* Fix keepassxreboot#10656 - Add a small delay when before auto-polling hardware keys to all them to settle immediately after plugging in. This resolves an issue where the key's serial number could not be resolved due to hardware timeout. * Also fix use of uninitialized variable if polling serial number fails for whatever reason. * Fix typo in macOS key registration code * Prevent registering duplicate listeners on window focus. These were not de-registered because we didn't trigger on unfocus. Show/Hide are sufficient triggers to add and remove listeners.
Overview
I have a new YubiKey 5C Nano (firmware 5.4.3). I have copied my keepass-database HMAC challenge to the new YubiKey. When I plug the YubiKey and try to login to my database, KeePassXC reports the wrong serial number for the hardware key and cannot interface with the hardware key.
Steps to Reproduce
Expected Behavior
Login without difficulty.
Actual Behavior
Wrong YubiKey serial number, database remains locked.
Context
The new YubiKey is attached directly to the Macbook Air. KeePassXC does not run under a virtual machine. Installed from Homebrew. Several other YubiKeys work correctly on the same computer. The affected YubiKey works correctly on the same computer with other applications (PGP) and also with KeePass-databases on an Android phone with Keepass2Android v. 1.10-pre. The affected YubiKey is the only one connected to the Mac at the time of testing.
KeePassXC - Version 2.7.7
Revision: 68e2dd8
Qt 5.15.11
Debugging mode is disabled.
Operating system: macOS 13.6
CPU architecture: x86_64
Kernel: darwin 22.6.0
Enabled extensions:
Cryptographic libraries:
NOTE:
Operating System: macOS
The text was updated successfully, but these errors were encountered: